lib: use msgspec json decoder for requests Session - #24894
Open
BeryJu wants to merge 1 commit into
Open
Conversation
✅ Deploy Preview for authentik-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #24894 +/- ##
==========================================
+ Coverage 91.41% 91.43% +0.01%
==========================================
Files 1146 1147 +1
Lines 71815 71873 +58
Branches 3875 3875
==========================================
+ Hits 65653 65718 +65
+ Misses 6127 6120 -7
Partials 35 35
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. |
BeryJu
changed the title
BeryJu
force-pushed
the
lib/http/requests-json-msgspec
branch
from
August 7, 2026 23:41
dba51a9 to
4449b43
Compare
Contributor
|
authentik PR Installation instructions Instructions for docker-composeAdd the following block to your AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-50ec153a5881eacfb464f2fb71b708ee2f9a70e2
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)sAfterwards, run the upgrade commands from the latest release notes. Instructions for KubernetesAdd the following block to your authentik:
outposts:
container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
global:
image:
repository: ghcr.io/goauthentik/dev-server
tag: gh-50ec153a5881eacfb464f2fb71b708ee2f9a70e2Afterwards, run the upgrade commands from the latest release notes. |
BeryJu
force-pushed
the
lib/evaluator/lazy-session
branch
from
August 8, 2026 12:41
dc0249c to
44ed01c
Compare
BeryJu
force-pushed
the
lib/http/requests-json-msgspec
branch
from
August 8, 2026 12:41
4449b43 to
47aa3a6
Compare
BeryJu
force-pushed
the
lib/evaluator/lazy-session
branch
from
August 9, 2026 16:37
44ed01c to
217f373
Compare
BeryJu
force-pushed
the
lib/http/requests-json-msgspec
branch
3 times, most recently
from
August 9, 2026 17:01
1e0370a to
a423dcb
Compare
✅ Deploy Preview for authentik-storybook ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
BeryJu
force-pushed
the
lib/http/requests-json-msgspec
branch
from
August 9, 2026 17:55
a423dcb to
dce5a72
Compare
Signed-off-by: Jens Langhammer <jens@goauthentik.io>
BeryJu
force-pushed
the
lib/http/requests-json-msgspec
branch
from
August 9, 2026 18:03
dce5a72 to
50ec153
Compare
rissson
approved these changes
Aug 10, 2026
rissson
left a comment
rissson
left a comment
Member
There was a problem hiding this comment.
Just a small testing thing, otherwise LGTM
| session = get_http_session() | ||
| self.assertIsInstance(session, DebugSession) | ||
| self.assertIsInstance(session.get_adapter("https://goauthentik.io"), MsgspecHTTPAdapter) | ||
| self.assertIsInstance(session.get_adapter("http://goauthentik.io"), MsgspecHTTPAdapter) |
Member
There was a problem hiding this comment.
Any way we could add a test to ensure that the msgspec decoder is used by default? So that in future requests versions, if they start passing args to the json method, we can catch that?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the last one